[zcash/zcash] Support testnet rollback. (#3443)

@str4d wrote:
> @Eirik0 wrote:
> > Also, this may be a silly question, or overly complicated to do, but would it make sense to try to update rewind_index.py to test these changes?
>
> It’s impossible, because the RPC tests use regtest mode, while the changes solely affect testnet. Even if we worked around that, we can’t recreate the exact desired hash in regtest anyway as we can’t (yet) break SHA256d.

We could test it by adding a general mechanism to set long-rollback exceptions from tests, in the same way that we can set network upgrade activations from tests. I’m not sure it’s worth the complexity.

Добавить комментарий