[ripple/rippled] Modernize CMake Build (#2579)

mellery451 commented on this pull request.

> +add_custom_command (TARGET sqlite3 POST_BUILD
+ COMMAND ${CMAKE_COMMAND} -E copy_directory
+ ${CMAKE_CURRENT_SOURCE_DIR}/src/sqlite/sqlite ${CMAKE_BINARY_DIR}/sqlite3/include
+ $ ${CMAKE_BINARY_DIR}/sqlite3/lib
+ BYPRODUCTS ${CMAKE_BINARY_DIR}/sqlite3/include/sqlite3.h)
+ NIH dep: soci
+add_library (soci STATIC
+ #[=========================================================[
+ this unity file is our interpretation of
+ what sources comprise soci-lib.
+ (this must be investigated/confirmed whenever updated)

I think comment is confusing and I’ll remove it. What I meant is that we (at some point) decided we knew what files constitute the SOCI library and we made a unity file to represent this. Whenever you update the underlying project, it’s possible files could be added/renamed/removed/etc. and thus the unity file should be reviewed for accuracy. I plan in the near future to make soci and rocksdb external projects and get out of the business of deciding what files (and settings) are needed for these projects — they have their own build systems to make these decisions.

Добавить комментарий