JoeLoser commented on this pull request.
> + -Wno-unused-function
+add_library (NIH::snappy ALIAS snappy)
+target_link_libraries (ripple_libs INTERFACE NIH::snappy)
+ NIH dep: rocksdb
+CHECK_CXX_COMPILER_FLAG (“-std=c++11” COMPILER_SUPPORTS_CXX11)
I think we can safely remove this as rippled only supports the following min compilers as far as I can tell:
1. GCC 5+
2. Clang x+ (3.7ish probably based on features used that I’ve seen?)
3. MSVC 2017?
In any regard, all of these compilers support cpp11 flag. I think we should guarantee our expectations of min compiler support very early on (I think we do already) — well before NIH 3rd party lib CMake stuff.
This post was last modified on June 14, 2018, 6:26 am