[ripple/rippled] Modernize CMake Build (#2579)

JoeLoser commented on this pull request.

> +
+if (NOT MSVC)
+ set (THREADS_PREFER_PTHREAD_FLAG ON)
+ find_package (Threads)
+ target_link_libraries (ripple_syslibs INTERFACE Threads::Threads)
+endif ()
+
+add_library (ripple_libs INTERFACE)
+add_library (Ripple::libs ALIAS ripple_libs)
+target_link_libraries (ripple_libs INTERFACE Ripple::syslibs)
+
+#[===================================================================[
+ NIH dep: boost
+#]===================================================================]
+
+if ((NOT DEFINED BOOST_ROOT) AND (DEFINED ENV{BOOST_ROOT}))

Can you help me understand why we support both CMake defines *and* environment variables? I’ve been wondering it since I first jumped into the codebase. It seems like we could just get away with CMake defines at `configure` time.

Добавить комментарий