[ripple/rippled] Increase validation quorum to 80% (#2613)

wilsonianb commented on this pull request.

> {
— quorum = *minimumQuorum_;
— JLOG (j_.warn())
— << "Using unsafe quorum of " - << quorum_ - << " as specified in the command line"; + if (TimeKeeper::time_point{} < list.second.expiration && This wasn't actually changed in this PR, but I'm glad you pointed it out. We do require fetched published lists to have an expiration https://github.com/ripple/rippled/blob/develop/src/ripple/app/misc/impl/ValidatorList.cpp#L355 However before fetching, we populate `publisherLists_` with `PublisherList` objects when reading the publisher keys from the config, in which case we have default-constructed time point. https://github.com/ripple/rippled/blob/develop/src/ripple/app/misc/impl/ValidatorList.cpp#L121 What's wrong here is that this check should instead be checking `available`. As is, we will call `removePublisherList` for the same expired list every time. This is fixed in https://github.com/ripple/rippled/pull/2613/commits/5f549e60118619774201b68fdcf90f4cccc69c9b

Добавить комментарий