[monero-project/monero] wallet: warn when payment IDs are used (#4109)

xiphon commented on this pull request.

> @@ -3955,6 +3955,19 @@ void simple_wallet::on_money_received(uint64_t height, const crypto::hash &txid,
tr(“txid “) tx_extra_fields;
+ parse_tx_extra(tx.extra, tx_extra_fields); // failure ok
+ tx_extra_nonce extra_nonce;
+ if (find_tx_extra_field_by_type(tx_extra_fields, extra_nonce))
+ {
+ crypto::hash8 payment_id8 = crypto::null_hash8;

No reason to initialize it.
“`c++
crypto::hash8 payment_id8;
““

This post was last modified on July 8, 2018, 4:26 am