[EOSIO/eos] Remove magic number (#4382)

heifner commented on this pull request.

> } else if ( is_optional(type) ) {
– return type_name(string(type).substr(0, type.size()-1));
+ return type_name(string(type).substr(type.size()-optional_mark.size()));

This is not equivalent to the old code and is causing tests to fail. The first arg to `substr` is start position, second arg is length.

This post was last modified on July 6, 2018, 4:45 pm