[EOSIO/eos] Incorrect auth check in net_plugin if allowed-connection == ‘produsers’ (#3617)

If ‘allowed-connection’ param set only on ‘produsers’, nobody can’t connect to node.
This case check here:
https://github.com/EOSIO/eos/blob/ca03c3a7db7c7177a4790eb1655e444c3ad8b9bd/plugins/net_plugin/net_plugin.cpp#L2665

`found_producer_key` obtained here:
https://github.com/EOSIO/eos/blob/ca03c3a7db7c7177a4790eb1655e444c3ad8b9bd/plugins/net_plugin/net_plugin.cpp#L2664

but method [`is_producer_key`](https://github.com/EOSIO/eos/blob/ca03c3a7db7c7177a4790eb1655e444c3ad8b9bd/plugins/producer_plugin/producer_plugin.cpp#L426) returns `true` **only** if `msg.key` is our’s producer key which configured in node start config:

It seems param `allowed-connection = produsers` designed to allow any **producer** nodes(not only our`s) connect to node. If i’m right, that is bug.

Запись редактировалась последний раз: May 30, 2018, 10:30 pm

Рубрики: cryptocurrency EOSIO/eos