[bitshares/bitshares-core] Refactor cli_test #1192 (#1243)

cogutvalera commented on this pull request.

> {
— using namespace graphene::chain;
— using namespace graphene::app;
— std::shared_ptr app1;
— try {
— fc::temp_directory app_dir ( graphene::utilities::temp_directory_path() );
+ int server_port_number {0};
+ fc::temp_directory app_dir = graphene::utilities::temp_directory_path();
+ std::shared_ptr app1 = start_application(app_dir, server_port_number);
+ client_connection* con = new client_connection(app1, app_dir, server_port_number);

1. fixed indentation from 4 white spaces to 3
2. initializing variables in constructor has different compile errors, need to fight all them, trying to understand why they happened, still fighting …
3. I’ve used pointer because without pointer I had compile errors, still trying to understand why and still fighting with them …