251Labs commented on this pull request.
Nice job @PierreRochard! Tested ACK 553b1a7. Feedback is not critical, feel free to ignore it.
> @@ -1198,6 +1198,11 @@ class CWallet final : public CCryptoKeyStore, public CValidationInterface
/** Whether a given output is spendable by this wallet */
bool OutputEligibleForSpending(const COutput& output, const CoinEligibilityFilter& eligibility_filter) const;
A minor improvement could be to separate logging from the wallet interface by (i) implementing `WalletLogPrintf` as a non-member function; or (ii) implementing a `CWallet::GetDebugString(…)`-like method that returns the debug string, which can be passed to the `LogPrintf` macro.
This post was last modified on July 6, 2018, 11:32 pm