[bitcoin/bitcoin] travis: build and run tests on os: osx (#13816)

practicalswift commented on this pull request.

> @@ -27,5 +27,8 @@
# SC2166: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
# SC2166: Prefer [ p ] || [ q ] as [ p -o q ] is not well defined.
# SC2181: Check exit code directly with e.g. ‘if mycmd;’, not indirectly with $?.
-shellcheck -e SC2001,SC2004,SC2005,SC2006,SC2016,SC2028,SC2046,SC2048,SC2066,SC2086,SC2116,SC2148,SC2162,SC2166,SC2181 \
— $(git ls-files — «*.sh» | grep -vE ‘src/(secp256k1|univalue)/’)
+
+docker run -t -v $(pwd):/code -t koalaman/shellcheck-alpine:v0.5.0 \

@scravy With the suggested change everyone running the linter would effectively be vulnerable in case of a compromise of the `koalaman` Docker Hub account.

So a clear NACK from me on this specific change. Try to find a more lightweight workaround that doesn’t introduce any additional trust or dependencies.

Добавить комментарий