scravy commented on this pull request.
> @@ -27,5 +27,8 @@
# SC2166: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
# SC2166: Prefer [ p ] || [ q ] as [ p -o q ] is not well defined.
# SC2181: Check exit code directly with e.g. ‘if mycmd;’, not indirectly with $?.
-shellcheck -e SC2001,SC2004,SC2005,SC2006,SC2016,SC2028,SC2046,SC2048,SC2066,SC2086,SC2116,SC2148,SC2162,SC2166,SC2181 \
— $(git ls-files — «*.sh» | grep -vE ‘src/(secp256k1|univalue)/’)
+docker run -t -v $(pwd):/code -t koalaman/shellcheck-alpine:v0.5.0 \
@practicalswift What is the problem with a docker dependency? To me it seems like the shellcheck binary in ubuntu trusty is broken and segfaults under certain conditions. Here is an issue: https://github.com/koalaman/shellcheck/issues/1053 The docker image pulled in is the official build of shellcheck.
For me to understand: Introducing a dependency for example using `brew` on osx — is that okay or not?