jamesob commented on this pull request.
+ thread_util::Rename((“httpworker.” + std::to_string(worker_num)).c_str());
This commit seems tough to split up in a meaningful way. Hopefully the reduced size of the `threadutil` change (now that we aren’t doing anything with a generic thread data struct) makes it easier to review, but it’ll take a lot of rework to stage the changes out as you suggest. I’m happy to do this if you think it’s worthwhile, but wanted to check before doing so to see if the simplifications make a difference for this recommendation.
This post was last modified on June 14, 2018, 4:51 pm