sipa commented on this pull request.
+ * TODO: using thread_local changes the abi in ways that may not play nice
+ * when the c++ stdlib is linked dynamically. Disable it until thorough
+ * testing has been done.
+ * mingw32’s implementation of thread_local has also been shown to behave
+ * erroneously under concurrent usage; see:
+ * https://gist.github.com/jamesob/fe9a872051a88b2025b1aa37bfa98605
I think this line may be unintentional.
> +#elif defined(MAC_OSX)
+ // Prevent warnings for unused parameters…
+ return “”;
+ char threadname_buff;
+ char* pthreadname_buff = (char*)(&threadname_buff);
I don’t think you need this variable; using `threadname_buff` will automatically decay to `(char *)`.
This post was last modified on May 7, 2018, 5:37 pm