[bitcoin/bitcoin] Don’t edit Chainparams after initialization (#13311)

jtimon commented on this pull request.

> {
— globalChainParams->UpdateVersionBitsParameters(d, nStartTime, nTimeout);
+ SelectBaseParams(network);
+ globalChainParams = CreateChainParams(network, gArgs);

I guess one can mutate gArgs to a given value for a given test and then back to its original value afterwards.
Or as you say, make this change afterwards when it’s going to be used.