[bitcoin/bitcoin] Don’t assert(foo()) where foo() has side effects (#13534)

Empact commented on this pull request.

> @@ -41,7 +41,8 @@ static CTxIn MineBlock(const CScript& coinbase_scriptPubKey)
auto block = PrepareBlock(coinbase_scriptPubKey);

while (!CheckProofOfWork(block->GetHash(), block->nBits, Params().GetConsensus())) {
– assert(++block->nNonce);
+ block->nNonce++;

nit: could be `++block->nNonce` as before

This post was last modified on July 7, 2018, 3:16 am