[bitcoin/bitcoin] Dandelion transaction relay (BIP 156) (#13947)

MarcoFalke commented on this pull request.

> @@ -120,6 +120,11 @@ extern const char *GETHEADERS;
* @see https://bitcoin.org/en/developer-reference#tx
*/
extern const char *TX;
+/**
+ * The dandelion tx message transmits a single transaction.
+ * @see https://github.com/bitcoin/bips/blob/master/bip-0156.mediawiki
+ */
+extern const char* TX_DANDELION;

Good point. I think it is a lot easier to do this without enforcing a global network version bump.

Note that the `dandelionacc` message is properly read by all nodes that implement dandelion (regardless of their network protocol version) or choose to ignore that message. And for all other nodes (that are completely unaware of dandelion) they simply treat this as unknown message (once per connection) in their logs. I think this one debug log is not enough reason to go through the hassle of bumping the protocol version.

https://github.com/bitcoin/bitcoin/blob/63f8b0128b2aac3b25c6ec4d2f5bda213033162a/src/net_processing.cpp#L2942

Добавить комментарий