[bitcoin/bitcoin] BIP 158: Compact Block Filters for Light Clients (#12254)

ryanofsky commented on this pull request.

> @@ -138,6 +138,80 @@ class CVectorWriter
size_t nPos;
};

+/* Minimal stream for reading from an existing vector by reference
+ */
+class CVectorReader
+{
+private:
+ const int nType;
+ const int nVersion;
+ const std::vector& vchData;

Re: https://github.com/bitcoin/bitcoin/pull/12254#discussion_r174888569

I think it would be better to replace VectorReader with SpanReader at this point. It’s a simple change that would make this class more flexible and reusable.

Добавить комментарий